Fix the bug with SIGTERM non-graceful handling #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Demin <a.demin@thebeat.co>
Signed-off-by: Alex Demin <a.demin@thebeat.co>
mantzas
requested changes
Aug 6, 2020
component/http/component.go
Outdated
| cb.errors = append(cb.errors, errors.New("negative or zero shutdown grace period provided")) | ||
| } else { | ||
| log.Infof("setting shutdown grace period") | ||
| cb.httpWriteTimeout = gp |
There was a problem hiding this comment.
yes, was a typo, fixed in 49ebea3
Codecov Report
@@ Coverage Diff @@
## master #247 +/- ##
==========================================
+ Coverage 73.16% 73.22% +0.05%
==========================================
Files 61 61
Lines 3667 3675 +8
==========================================
+ Hits 2683 2691 +8
Misses 907 907
Partials 77 77
Continue to review full report at Codecov.
|
Signed-off-by: Alex Demin <a.demin@thebeat.co>
mantzas
approved these changes
Aug 6, 2020
Stefos
pushed a commit
to Stefos/patron
that referenced
this pull request
Oct 8, 2020
Signed-off-by: Alex Demin <a.demin@thebeat.co> Co-authored-by: Sotirios Mantziaris <s.mantziaris@thebeat.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alex Demin a.demin@thebeat.co
Which problem is this PR solving?
This PR closes #246
Short description of the changes
Shutdownwith configurable timed context (default shutdown grace period is 5 seconds)BaseContextfrom http service.