Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust order of linked libraries to fix Ubuntu compilation #4

Merged

Conversation

pierricgimmig
Copy link
Contributor

This fixes #2 for me on Ubuntu 22.04

image

@beaufortfrancois
Copy link
Owner

Oh! I'm surprised by this PR! Thank you @pierricgimmig
@kainino0x Does this make sense to you?

@kainino0x
Copy link
Collaborator

I wouldn't have expected this to fix it, either. There must be something subtly wrong somewhere in (probably Dawn's) CMake files. Seems fine to land as a workaround though.

@beaufortfrancois beaufortfrancois merged commit 076ea4b into beaufortfrancois:main Oct 30, 2023
@beaufortfrancois
Copy link
Owner

Thank you @pierricgimmig!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dawn compilation error Ubuntu 22.04
3 participants