Add class exists check to OAuthException to avoid compat issue with PECL OAuth #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ECL OAuth extension
beaulebens
pushed a commit
that referenced
this pull request
Nov 29, 2015
Add class exists check to OAuthException to avoid compat issue with PECL OAuth
|
Not sure how I missed the notification for this existing, but thanks for the fix @sanchothefat ! |
|
No problem! I have a bunch more updates actually I'll get the PRs sorted Robert O'Rourke |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Beau,
I know the OAuth lib you use is from another source but this small change makes the plugin compatible with hosts that have the php-oauth module installed. Not too hard to implement on updates of the lib and it will mean Keyring works on hosts like Pantheon where I ran into the issue of it causing a fatal error on activation.