Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No notInArray() Assertion #113

Open
mdavis1982 opened this issue Aug 21, 2015 · 4 comments
Open

No notInArray() Assertion #113

mdavis1982 opened this issue Aug 21, 2015 · 4 comments

Comments

@mdavis1982
Copy link
Contributor

There are not* assertions for lots of methods, but there isn't one for notInArray. I need this assertion for a project I'm working on, and, at the moment, I'm having to do this manually unless there is a better way of doing it.

Would it be possible to add this assertion?
@TomasVotruba
Copy link
Contributor

@mdavis1982 Could you prepare PR?

@mdavis1982
Copy link
Contributor Author

@TomasVotruba I can potentially do that over the weekend

raphaelstolt added a commit to raphaelstolt/assert that referenced this issue Jul 27, 2016
@raphaelstolt
Add not in array assertion. Closes beberlei#113.
1f0e94d
raphaelstolt added a commit to raphaelstolt/assert that referenced this issue Jul 27, 2016
@raphaelstolt
Add not in array assertion. Closes beberlei#113.
61b460c
rquadling added a commit that referenced this issue Jul 28, 2016
@rquadling
Merge pull request #155 from raphaelstolt/not-in-array-assertion
3fa0eb5 
Add not in array assertion. Closes #113.
@rquadling
Copy link
Contributor

@mdavis1982 - could you comment on #246.

I'm happy to make notInArray work the same as inArray, but if there was any reasons to not use strict comparison, then that would be useful to know.

@rquadling rquadling reopened this Feb 16, 2018
@rquadling
Copy link
Contributor

My preference would be strict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rquadling @mdavis1982 @TomasVotruba