[BC Break] Intl is now a required dependency #288
Labels
Comments
This was referenced Sep 27, 2019
rquadling
pushed a commit
that referenced
this issue
Oct 10, 2019
Fixes #288. While #268 and #269 updated count() and isCountable() to now work with intl resources, #286 made that the whole beberlei/assert package now requires the intl extension to be installed. However, the intl extension dependency is a soft dependency. The package does not need intl for most of its features and can safely work without it.
beberlei
pushed a commit
that referenced
this issue
Apr 18, 2021
* Remove ext-intl as a required extension, making it a suggested extension for use with Assertion::count(), Assertion::isCountable(), Assertion::minCount(), and Assertion::maxCount() to operate on ResourceBundles. * Correct @method return typehint for LazyAssertion chaining * Restored `\Assert\Assertion::createException()` signature to 3.2.2. Sincerely apologies to the BC break. * Fix docblock typehint * Prepare v3.2.4 * Remove a hard dependency on the intl extension (#289) Fixes #288. While #268 and #269 updated count() and isCountable() to now work with intl resources, #286 made that the whole beberlei/assert package now requires the intl extension to be installed. However, the intl extension dependency is a soft dependency. The package does not need intl for most of its features and can safely work without it. * Fix docblocks for `all` to show that they are expected to receive an array of things * Preapare v3.2.5 * Make `Assert\Assertion::stringify()` UTF-8 safe. * Prepare v3.2.6 * Reinstate LazyAssertion docblock * ## 3.2.7 - 2019-12-19 ### Fixes - Reinstated the `@method` return type for `Assert\LazyAssertion` methods to show that the return type is `LazyAssertion`. * Fixes Co-authored-by: Richard Quadling <Richard.Quadling@DigiTickets.co.uk> Co-authored-by: Jakub Zalas <jakub@zalas.pl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
#286 made that the whole beberlei/assert package now requires the intl extension to be installed.
#268 and #269 updated count() and isCountable() to now work with intl resources.
It's what I'd call an optional dependency though. The Assertion class, and therefore the whole library, can work perfectly fine without the intl extension.
The intl extension is still not being commonly installed as for most projects it's of no benefit. IMO It's not nice to force people to install it because an assertion library "needs" it for some edge cases.
The text was updated successfully, but these errors were encountered: