-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding argument for modify some values in generated m3u file #47
Comments
Hi there, I think that this is a decent feature request that I would be willing to take on. A single new argument could work but I think it will be a better logical fit to introduce two new arguments, one that targets group name transformations and the other to target channel names. I suggest:
If you're ok with this idea I'll have a think about how these arguments will look for both CLI and JSON input. |
Hi, Love your suggestion :) Thank you. |
Ok it sounds like a goer, I'll take a look asap. I have reservations about introducing this same feature for the tvg-id / channel attribute at present due to this being the linking attribute between the m3u data and the epg data. I'm aware that service providers are notoriously bad at maintaining sensible (actually working) linkage data in this area but I feel attempting to fix this is a step too far at the moment. Let's get the above idea introduced first and then we can review. |
Ok, let's go for implementing the two arguments first ! However, I think an option for changing tvd-id value remains legit in case of service providers make typo error like I can find in my current m3u list: Users should probably understand that changing these values can cause problems with their epg ;) |
One new commit pushed to the master branch, give that a try. The They take a small blob of JSON that looks like the following:
and
String matching is case sensitive and regex pattern matching is not supported in this feature. Thanks. |
Hi, Hmmm, strange results here but not sure if is related to your modifications. Will make some investigations here... EDIT: Thanks. |
Jolly good, no catastrophic bug found yet by the sound of things. Please give this feature a bit of a test and let me know if it appears to be working as you expect it to. Thanks. |
Ok, the problem was due to regex search in is_item_matched() function :( Therefore this new feature works perfectly 👍 Maybe it will be better to change name of channel in addition to tvg-name by replacing Thank you. |
Thanks for confirming. I was in two minds about what to do about the |
Done, the If you really do want / need a tvg-id transform feature please open a new issue. Thanks. |
Thank you ! |
Hi,
What do you think about adding one option (argument) to be able to change/correct some values in generated m3u file (incorrect channel names, groups, id, etc..)
I add the code below to your python script but it would be nicer if we have a new argument option to use in command line or Json file ;)
Regards.
The text was updated successfully, but these errors were encountered: