Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/asset helper #12

Merged
merged 5 commits into from
Dec 19, 2019
Merged

Feat/asset helper #12

merged 5 commits into from
Dec 19, 2019

Conversation

stefanorosanelli
Copy link
Member

No description provided.

/**
* {@inheritDoc}
*/
public $helpers = ['Html'];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The HtmlHelper is not used

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@codecov-io
Copy link

codecov-io commented Dec 19, 2019

Codecov Report

Merging #12 into master will increase coverage by 0.82%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #12      +/-   ##
=========================================
+ Coverage     77.17%   78%   +0.82%     
- Complexity       90    94       +4     
=========================================
  Files            10    11       +1     
  Lines           241   250       +9     
=========================================
+ Hits            186   195       +9     
  Misses           55    55
Impacted Files Coverage Δ Complexity Δ
src/View/Helper/HtmlHelper.php 92% <ø> (ø) 36 <0> (ø) ⬇️
src/View/Helper/AssetHelper.php 100% <100%> (ø) 4 <4> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 341b2fe...e5db4cf. Read the comment docs.

@batopa batopa merged commit 154d999 into master Dec 19, 2019
@batopa batopa deleted the feat/asset-helper branch December 19, 2019 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants