fix unpacking too many values, taken from existing PR-#123 #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
any chance that this PR will be merged? |
|
@Tob0t I've accepted this PR over here: compwright#1 |
|
@bradvogel this is ready to go |
compwright
approved these changes
Nov 21, 2022
compwright
force-pushed
the
fixTooManyValueToUnpack
branch
from
d3f2458
to
c28f586
Compare
|
Resubmitted as #550 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since there is no progress on #123 I created another PR.
FYI: The commit from @mattbornski was taken.
Since our queues stopped working if there are more than 8k jobs with the same timestamp, we needed a fix asap. I know that the PR was not merged since there could be a further improvements. However as @mattbornski mentioned, better this fix with blocking redis for short time than processing no jobs at all.
We are already using this code on our production system since we needed a fix asap.
Disclaimer: I'm not a lua programmer, so feel free to adapt the PR ;)