fix: queues stop working when there are more than 8k jobs with the same timestamp #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compwright
force-pushed
the
fixTooManyValueToUnpack
branch
from
c28f586
to
c53dcc7
Compare
bradvogel
approved these changes
Nov 22, 2022
There was a problem hiding this comment.
Approving.
It looks like this was approved here but with this concern. However, I agree with the comment in the PR description that it's better to block Redis than to not process at all.
|
@tmeasday care to add a review before we move on this? |
beequeueci
pushed a commit
that referenced
this pull request
Nov 23, 2022
## [1.4.3](v1.4.2...v1.4.3) (2022-11-23) ### Bug Fixes * queues stop working when there are more than 8k jobs with the same timestamp ([#550](#550)) ([28ca743](28ca743))
|
🎉 This PR is included in version 1.4.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Seems reasonable but it would be good to have a test I guess (I'm no expert on how these tests work anymore, or ever really). |
|
@tmeasday You're absolutely right. I complete overlooked the fact that there wasn't a test 🤦♂️. I think this is OK to skip one for now since it's unlikely the original author is interested in adding one now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resubmitting #192 from @Tob0t and @mattbornski to rebase and re-run CI checks: