Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version file does not support line ending (.node-version) #198

Closed
shadowspawn opened this issue Dec 24, 2022 · 1 comment · Fixed by #199
Closed

Version file does not support line ending (.node-version) #198

shadowspawn opened this issue Dec 24, 2022 · 1 comment · Fixed by #199
Labels
bug Something isn't working

Comments

@shadowspawn
Copy link

Text files often have a line-ending. Depending on the editor, it may be difficult for the user to tell if there is a line-ending or not, or possibly the editor may add one automatically.

It looks like from my limited testing that nvm-rust does not allow the version file to have a trailing line-ending:

% hexdump -C .node-version 
00000000  31 30 2e 31 32 2e 30 0a                           |10.12.0.|
00000008
% nvm install       
Failed to parse .node-version: '10.12.0
'
Error: You did not pass a version and we did not find any version files (package.json#engines, .nvmrc) in the current directory.

(Full disclosure. I am not a user of nvm-rust! I took a look because I am interested in application support for .node-version: https://github.com/shadowspawn/node-version-usage)

@beeequeue
Copy link
Owner

Thank you for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants