fix issue #3776 #4160
Merged
fix issue #3776 #4160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems that the unit test will fail with postgresql. Pls wait and I will fix it. |
flycash
reviewed
Aug 14, 2020
pkg/orm/orm_raw.go
Outdated
| fd := field.Addr().Interface().(Fielder) | ||
| err := fd.SetRaw(value) | ||
| if err != nil { | ||
| return fmt.Errorf("set raw error:%s", err) |
There was a problem hiding this comment.
What about using github.com/pkg/errors, we can change it in the future. I will check this PR this weekend.
There was a problem hiding this comment.
Sure. But I wonder what's the difference between errors.New() and fmt.Errorf() ?
flycash
approved these changes
Aug 14, 2020
This was referenced Aug 24, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3776
fix the bug that
Fielder'sSetRawis not called when callingorm.Raw()to query from database