-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom log formatter secondpr #4179
Custom log formatter secondpr #4179
Conversation
3dda0f2
to
e1da804
Compare
CI failed on second build. This failure below usually seems to happen so I'm not sure what the problem is:
I'll push another commit and see if it fixes itself |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Next PR maybe we could focus on:
How users register their custom LogFormat
and how all implementations use those LogFormat
?
Just ignore this error. This unit test is not stable. I can retry CI until it success. |
Yes so the last PR will be the full implementation of users setting their own formatters right? Just to get this right the order for the formatters should go as follows: adapter-specific formatter > global formatter > default formatter So using |
I'll write up a PR with the new logging documentation on beedoc after I finish this next PR. |
Just kindly remind you that I create a new branch named "ftr/log_format" and please use this branch as base branch. |
Second PR of the custom log formatter. I found this one to be very closely coupled to the third part so I found it quite hard.
LogFormatter
is implemented but no custom formatting is implemented yet which will come in the third PR.Most of the work will come in the third actually so this pr isn't very important at all
Works fully with