Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: implement the time precison for time.Time type #4186

Merged
merged 1 commit into from
Aug 25, 2020
Merged

Feature: implement the time precison for time.Time type #4186

merged 1 commit into from
Aug 25, 2020

Conversation

AllenX2018
Copy link
Collaborator

Fixes #3875

flycash
flycash reviewed Aug 24, 2020
View reviewed changes
Copy link
Collaborator

@flycash flycash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I will resolve the problem that cuts off time string and then merge it.

flycash
flycash reviewed Aug 24, 2020
View reviewed changes
Copy link
Collaborator

@flycash flycash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check https://github.com/flycash/beego/tree/ftr/time-precision. I think I resolved the problem. And please add more unit tests.

@AllenX2018 AllenX2018 closed this Aug 25, 2020
@AllenX2018 AllenX2018 deleted the Feature-datetime-precision branch August 25, 2020 03:34
@AllenX2018 AllenX2018 restored the Feature-datetime-precision branch August 25, 2020 03:35
@AllenX2018 AllenX2018 reopened this Aug 25, 2020
@flycash flycash merged commit cceecad into beego:develop-2.0 Aug 25, 2020
@flycash flycash mentioned this pull request Aug 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flycash flycash flycash left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AllenX2018 @flycash