Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Env: non-empty GOBIN & GOPATH #4613

Merged
merged 2 commits into from
May 19, 2021
Merged

Env: non-empty GOBIN & GOPATH #4613

merged 2 commits into from
May 19, 2021

Conversation

Loyalsoldier
Copy link
Contributor

Return non-empty GOBIN & GOPATH environment variable if not set explicitly by user.

@flycash
Copy link
Collaborator

flycash commented May 17, 2021

CI failed, please check it.

@Loyalsoldier Loyalsoldier marked this pull request as draft May 17, 2021 13:47
@Loyalsoldier Loyalsoldier marked this pull request as ready for review May 19, 2021 08:38
@Loyalsoldier
Copy link
Contributor Author

CI failed without enough error information. Any idea?

@flycash
Copy link
Collaborator

flycash commented May 19, 2021

image
@Loyalsoldier

@flycash
Copy link
Collaborator

flycash commented May 19, 2021

We don't care about the order of changes in the CHANGELOG.md. So you could choose any line of CHANGELOG.md you want to write the change. It could reduce the conflicts

CHANGELOG.md Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented May 19, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.7% 0.7% Duplication

@Loyalsoldier
Copy link
Contributor Author

Done.

@codecov-commenter
Copy link

codecov-commenter commented May 19, 2021

Codecov Report

Merging #4613 (08063ef) into develop (3815d38) will increase coverage by 0.00%.
The diff coverage is 51.02%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #4613   +/-   ##
========================================
  Coverage    54.56%   54.57%           
========================================
  Files          240      240           
  Lines        17505    17552   +47     
========================================
+ Hits          9552     9579   +27     
- Misses        7021     7038   +17     
- Partials       932      935    +3     
Impacted Files Coverage Δ
core/config/env/env.go 62.85% <51.02%> (-28.45%) ⬇️
task/task.go 65.78% <0.00%> (+0.65%) ⬆️
server/web/session/sess_mem.go 30.58% <0.00%> (+2.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3815d38...08063ef. Read the comment docs.

@flycash flycash merged commit 069cbd5 into beego:develop May 19, 2021
@Loyalsoldier Loyalsoldier deleted the env-default-GOPATH-GOBIN branch May 19, 2021 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants