Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/config/xml): prompt error when config format is incorrect #4757

Merged
merged 3 commits into from
Aug 31, 2021

Conversation

a631807682
Copy link
Contributor

close #4698

@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2021

Codecov Report

Merging #4757 (bf815a3) into develop (5628246) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4757      +/-   ##
===========================================
- Coverage    54.45%   54.44%   -0.02%     
===========================================
  Files          243      243              
  Lines        21711    21717       +6     
===========================================
+ Hits         11823    11824       +1     
- Misses        8936     8939       +3     
- Partials       952      954       +2     
Impacted Files Coverage Δ
core/config/xml/xml.go 48.73% <100.00%> (+2.72%) ⬆️
adapter/session/session.go 29.26% <0.00%> (-4.88%) ⬇️
task/task.go 68.01% <0.00%> (-0.81%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5628246...bf815a3. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Aug 31, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.5% 0.5% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

beego/adapter/config.NewConfig() crashed with an invalid xmlcontext
3 participants