Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate/Remove master-jdk17 branch #386

Closed
jjfumero opened this issue Apr 23, 2024 · 3 comments
Closed

Deprecate/Remove master-jdk17 branch #386

jjfumero opened this issue Apr 23, 2024 · 3 comments
Assignees
@jjfumero @mikepapadim @kotselidis @mairooni @stratika
Labels
dependencies Pull requests that update a dependency file proposal New proposals question Further information is requested

Comments

@jjfumero
Copy link
Member

Is your feature request related to a problem? Please describe.

Since TornadoVM moved to OpenJDK 21 with Panama Memory API, there is a compatibility issue with JDK 17. Thus, for known use cases using JDK17, TornadoVM had the option to run with jdk17 without the Panama integration.
However, all known uses cases for TornadoVM as well as running projects (e.g., AERO), are running with JDK21+, so there is no need to maintain the old one.

Besides, with JDK22, the JVMCI/GraalVM integration has also changed, which means that TornadoVM will have a new branch as well for JDK22+ changes.

Describe the solution you'd like

I suggest removing the JDK 17 branch and focus to 21 as minimum from now on.

Describe alternatives you've considered

n/a.

Additional context
n/a.
@jjfumero jjfumero added question Further information is requested proposal New proposals dependencies Pull requests that update a dependency file labels Apr 23, 2024
@mikepapadim
Copy link
Member

mikepapadim commented Apr 29, 2024 •
edited
Loading

Lets remove it as we have support with the latest LTS(21).

Also, as we add support for JDK22 which does not have backwards compatiblity due to graalvm paths change, we will end up maintaining 3 different jdks version (17, 21, 22).

I agree, then lets remove it.

@kotselidis
Copy link
Member

I agree lets remove it for the aforementioned reasons.

@jjfumero
Copy link
Member Author

OK, I am deleting the branch.

jjfumero added a commit to jjfumero/TornadoVM that referenced this issue Apr 30, 2024
@jjfumero
[release] TornadoVM v1.0.4
fbe53f2 
Improvements
~~~~~~~~~~~~~~~~~~

- [beehive-lab#369](beehive-lab#369): Introduction of Tensor types in TornadoVM API and interoperability with ONNX Runtime.
- [beehive-lab#370](beehive-lab#370): Array concatenation operation for TornadoVM native arrays.
- [beehive-lab#371](beehive-lab#371): TornadoVM installer script ported for Windows 10/11.
- [beehive-lab#372](beehive-lab#372): Add support for ``HalfFloat`` (``Float16``) in vector types.
- [beehive-lab#374](beehive-lab#374): Support for TornadoVM array concatenations from the constructor-level.
- [beehive-lab#375](beehive-lab#375): Support for TornadoVM native arrays using slices from the Panama API.
- [beehive-lab#376](beehive-lab#376): Support for lazy copy-outs in the batch processing mode.
- [beehive-lab#377](beehive-lab#377): Expand the TornadoVM profiler with power metrics for NVIDIA GPUs (OpenCL and PTX backends).
- [beehive-lab#384](beehive-lab#384): Auto-closable Execution Plans for automatic memory management.

Compatibility
~~~~~~~~~~~~~~~~~~

- [beehive-lab#386](beehive-lab#386): OpenJDK 17 support removed.
- [beehive-lab#390](beehive-lab#390): SapMachine OpenJDK 21 supported.
- [beehive-lab#395](beehive-lab#395): OpenJDK 22 and GraalVM 22.0.1 supported.
- TornadoVM tested with Apple M3 chips.

Bug Fixes
~~~~~~~~~~~~~~~~~~

- [beehive-lab#367](beehive-lab#367): Fix for Graal/Truffle languages in which some Java modules were not visible.
- [beehive-lab#373](beehive-lab#373): Fix for data copies of the ``HalfFloat`` types for all backends.
- [beehive-lab#378](beehive-lab#378): Fix free memory markers when running multi-thread execution plans.
- [beehive-lab#379](beehive-lab#379): Refactoring package of vector api unit-tests.
- [beehive-lab#380](beehive-lab#380): Fix event list sizes to accommodate profiling of large applications.
- [beehive-lab#385](beehive-lab#385): Fix code check style.
- [beehive-lab#387](beehive-lab#387): Fix TornadoVM internal events in OpenCL, SPIR-V and PTX for running multi-threaded execution plans.
- [beehive-lab#388](beehive-lab#388): Fix of expected and actual values of tests.
- [beehive-lab#392](beehive-lab#392): Fix installer for using existing JDKs.
- [beehive-lab#389](beehive-lab#389): Fix ``DataObjectState`` for multi-thread execution plans.
- [beehive-lab#396](beehive-lab#396): Fix JNI code for the CUDA NVML library access with OpenCL.
@jjfumero jjfumero mentioned this issue Apr 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jjfumero jjfumero

@mikepapadim mikepapadim

@kotselidis kotselidis

@mairooni mairooni

@stratika stratika

Labels
dependencies Pull requests that update a dependency file proposal New proposals question Further information is requested
Projects
TornadoVM 1.X (Public)
Status: Done
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jjfumero @mikepapadim @kotselidis @mairooni @stratika