Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to construct TornadoNativeArrays from ByteBuffers through memory segment direct copies #402

Merged
merged 4 commits into from
May 9, 2024

Conversation

mikepapadim
Copy link
Member

@mikepapadim mikepapadim commented May 2, 2024

Description

Currently, we support building TornadoNative arrays directly from primitive arrays and MemorySegments, but we were missing support for Java NIO ByteBuffers.

Example usage:

  // Step 1: Create and populate a FloatBuffer
  FloatBuffer buffer = FloatBuffer.allocate(5); // Allocate a FloatBuffer with capacity for 5 floats
  buffer.put(new float[]{1.0f, 2.0f, 3.0f, 4.0f, 5.0f}); // Put some values into the buffer
  buffer.flip(); // Reset the position to the start of the buffer to read from it

  // Step 2: Use the fromFloatBuffer method to create a FloatArray
  FloatArray floatArray = FloatArray.fromFloatBuffer(buffer);

Backend/s tested

Mark the backends affected by this PR.

  • OpenCL
  • PTX
  • SPIRV

OS tested

Mark the OS where this PR is tested.

  • Linux
  • OSx
  • Windows

Did you check on FPGAs?

If it is applicable, check your changes on FPGAs.

  • Yes
  • No

How to test the new patch?

make 

 tornado-test -V uk.ac.manchester.tornado.unittests.api.TestBuildFromByteBuffers
WARNING: Using incubator modules: jdk.incubator.vector

Test: class uk.ac.manchester.tornado.unittests.api.TestBuildFromByteBuffers
	Running test: testBuildFromFloatBuffer   ................  [PASS] 
	Running test: testBuildFromDoubleBuffer  ................  [PASS] 
	Running test: testBuildFromIntBuffer     ................  [PASS] 
	Running test: testBuildFromLongBuffer    ................  [PASS] 
	Running test: testBuildFromShortBuffer   ................  [PASS] 
	Running test: testBuildFromCharBuffer    ................  [PASS] 
Test ran: 6, Failed: 0, Unsupported: 0

@mikepapadim mikepapadim added the API label May 2, 2024
@mikepapadim mikepapadim self-assigned this May 2, 2024
@jjfumero
Copy link
Member

jjfumero commented May 2, 2024

Thanks Michali. Let's add also unit tests.

@mikepapadim
Copy link
Member Author

mikepapadim commented May 2, 2024

Done, I added the unit-tests in a seperate class from the rest of the API constructors in case we want to deprecate/remote in the near future in favour of the Memory segment utilities. So, we can easilty remove it.

Copy link
Member

@jjfumero jjfumero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikepapadim mikepapadim requested a review from stratika May 8, 2024 11:07
Copy link
Collaborator

@mairooni mairooni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@stratika stratika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, also tested the new tests on M1.

@jjfumero jjfumero merged commit fef96db into beehive-lab:develop May 9, 2024
2 checks passed
jjfumero added a commit to jjfumero/TornadoVM that referenced this pull request May 28, 2024
Improvements
~~~~~~~~~~~~~~~~~~

- beehive-lab#402 <beehive-lab#402>: Support for TornadoNativeArrays from FFI buffers.
- beehive-lab#403 <beehive-lab#403>: Clean-up and refactoring for the code analysis of the loop-interchange.
- beehive-lab#405 <beehive-lab#405>: Disable Loop-Interchange for CPU offloading..
- beehive-lab#407 <beehive-lab#407>: Debugging OpenCL Kernels builds improved.
- beehive-lab#410 <beehive-lab#410>: CPU block scheduler disabled by default and option to switch between different thread-schedulers added.
- beehive-lab#418 <beehive-lab#418>: TornadoOptions and TornadoLogger improved.
- beehive-lab#423 <beehive-lab#423>: MxM using ns instead of ms to report performance.
- beehive-lab#425 <beehive-lab#425>: Vector types for ``Float<Width>`` and ``Int<Width>`` supported.
- beehive-lab#429 <beehive-lab#429>: Documentation of the installation process updated and improved.
- beehive-lab#432 <beehive-lab#432>: Support for SPIR-V code generation and dispatcher using the TornadoVM OpenCL runtime.

Compatibility
~~~~~~~~~~~~~~~~~~

- beehive-lab#409 <beehive-lab#409>: Guidelines to build the documentation.
- beehive-lab#411 <beehive-lab#411>: Windows installer improved.
- beehive-lab#412 <beehive-lab#412>: Python installer improved to check download all Python dependencies before the main installer.
- beehive-lab#413 <beehive-lab#413>: Improved documentation for installing all configurations of backends and OS.
- beehive-lab#424 <beehive-lab#424>: Use Generic GPU Scheduler for some older NVIDIA Drivers for the OpenCL runtime.
- beehive-lab#430 <beehive-lab#430>: Improved the installer by checking  that the TornadoVM environment is loaded upfront.

Bug Fixes
~~~~~~~~~~~~~~~~~~

- beehive-lab#400 <beehive-lab#400>: Fix batch computation when the global thread indexes are used to compute the outputs.
- beehive-lab#414 <beehive-lab#414>: Recover Test-Field unit-tests using Panama types.
- beehive-lab#415 <beehive-lab#415>: Check style errors fixed.
- beehive-lab#416 <beehive-lab#416>: FPGA execution with multiple tasks in a task-graph fixed.
- beehive-lab#417 <beehive-lab#417>: Lazy-copy out fixed for Java fields.
- beehive-lab#420 <beehive-lab#420>: Fix Mandelbrot example.
- beehive-lab#421 <beehive-lab#421>: OpenCL 2D thread-scheduler fixed for NVIDIA GPUs.
- beehive-lab#422 <beehive-lab#422>: Compilation for NVIDIA Jetson Nano fixed.
- beehive-lab#426 <beehive-lab#426>: Fix Logger for all backends.
- beehive-lab#428 <beehive-lab#428>: Math cos/sin operations supported for vector types.
- beehive-lab#431 <beehive-lab#431>: Jenkins files fixed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants