Removed the default keybind that bound esc to cancel query

[austinwilcox]

This contains the fix for Issue 1716. Esc was by default set to still cancel query instead of being handled later by checking to see if the user was using vim keybindings. This is a one liner change.

[rathboma]

In your PR - does Esc still cancel the query, but it's bound elsewhere?

[austinwilcox]

          if(this.userKeymap === "vim") {
            runQueryKeyMap["Ctrl-Esc"] = this.cancelQuery
          } else {
            runQueryKeyMap.Esc = this.cancelQuery
          }

This is the code that handles adding esc to cancel the query for regular users, it's just a couple lines below the longer list of keybindings. I will run a couple of quick tests and make sure it will still cancel the query for users not using vim.

[austinwilcox]

I can confirm that it does still cancel the query for default keybindings, and for vim keybindings it works with Ctrl+Esc.

[austinwilcox]

Here is a quick gif showing that, I still need to get something like screenkey running on my box so you can see the keypresses.

[rathboma]

Thanks Austin!

[austinwilcox]

You're welcome. Happy to support the project where I can.