Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: notify query execute successfully when app is not focused. #1855

Merged

Conversation

invisal
Copy link
Contributor

@invisal invisal commented Jan 5, 2024

#1435

We will push notification only when the app is not in focused. We can make the notification look better if we have some images.

For Windows Screenshot
image

For Mac Screenshot
image

How to test

  • Connect to MySQL server.
  • Run this query SELECT SLEEP(10);
  • Open other app besides Beekeeper and wait
  • The notification will show after 10 seconds when it is complete.

@rathboma
Copy link
Collaborator

rathboma commented Jan 5, 2024

This is awesome! Does this create a native notification on different OSes, or a weird electron-looking one?

@invisal
Copy link
Contributor Author

invisal commented Jan 6, 2024

I believe it should be native. In Window, it appears in the bottom right side. I will try to test on Mac to see how it looks like, but because my Mac is M1, it seem to have some problem running the project. Let me try again and provide you with Mac screenshot.

@invisal
Copy link
Contributor Author

invisal commented Jan 6, 2024

@rathboma I have updated the screenshot for Mac. The thing that need to do is wording. My english is terrible and maybe you can give suggestion.

@rathboma rathboma merged commit 14ddcda into beekeeper-studio:master Jan 19, 2024
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants