Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: notify query execute successfully when app is not focused. #1855

Merged
merged 3 commits into from
Jan 19, 2024
Merged

feat: notify query execute successfully when app is not focused. #1855

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6762f42
feat: notify query execute successfully when app is not focus
invisal Jan 5, 2024
85978d0
feat: check for notification permission before push
invisal Jan 6, 2024
df2fe79
Merge branch 'master' into feat/long-query-notification
rathboma Jan 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 8 additions & 0 deletions apps/studio/src/components/TabQueryEditor.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1100,6 +1100,14 @@
const queryStartTime = new Date()
const results = await this.runningQuery.execute()
const queryEndTime = new Date()

// https://github.com/beekeeper-studio/beekeeper-studio/issues/1435
if (!document.hasFocus() && window.Notification && Notification.permission === "granted") {
new window.Notification("Query Complete", {
body: `${this.tab.title} has been executed successfully.`,
});
}

// eslint-disable-next-line
// @ts-ignore
this.executeTime = queryEndTime - queryStartTime
Expand Down