A couple of tabulator navigation small issues #2146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rathboma
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I initially searched for an issue but ended up seeing a couple of small issues related to the Select Range (spreadsheet) navigation.
If we navigate on a big table using
Ctrl+Arrow(tryfilmin postgres), it can stop in any position unpredictably. fix jump navigation in Select Range olifolkerd/tabulator#4473 <-- this also fixes BUG: TableTable ctrl+arrow movement breaks cell selection #2078Tabulator doesn't completely trap the keyboard events, so if we have a keybinding that's conflicting with tabulator, our keybinding can be triggered, even though tabulator is on focus. Trap focus key navigation in Select Range olifolkerd/tabulator#4474
Pressing an arrow key after selecting a range of multiple cells should break the selection and continue navigating. This sometimes doesn't happen. Break expanded range after pressing arrow keys olifolkerd/tabulator#4478
Autoscrolling to a big column is more sensible now. fix autoscroll on long columns olifolkerd/tabulator#4479