Fix: xml: Only test write permissions for attributes that are being c…

…hanged
beekhof · Mar 4, 2014 · 07609cf · 07609cf
1 parent a802f9a
commit 07609cf
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/lib/common/xml.c b/lib/common/xml.c
@@ -2290,10 +2290,6 @@ crm_xml_add(xmlNode * node, const char *name, const char *value)
                   return value);
     }
 #endif
-    if(__xml_acl_check(node, name, xpf_acl_create) == FALSE) {
-        crm_trace("Cannot add %s=%s to %s", name, value, node->name);
-        return NULL;
-    }
 
     if(TRACKING_CHANGES(node)) {
         const char *old = crm_element_value(node, name);
@@ -2303,6 +2299,11 @@ crm_xml_add(xmlNode * node, const char *name, const char *value)
         }
     }
 
+    if(dirty && __xml_acl_check(node, name, xpf_acl_create) == FALSE) {
+        crm_trace("Cannot add %s=%s to %s", name, value, node->name);
+        return NULL;
+    }
+
     attr = xmlSetProp(node, (const xmlChar *)name, (const xmlChar *)value);
     if(dirty) {
         crm_attr_dirty(attr);