Fix various minor inconsistencies in entry list item offsets #1318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexbakker
force-pushed
the
no-compact-divider
branch
from
0de9517
to
d880099
Compare
michaelschattgen
requested changes
Mar 19, 2024
This patch addresses the following: - More consistent offsets between entries in the list, especially in relation to the action bar and the error card. - Consistent correct application of card shapes when switching between favoriting and unfavoriting entries. - Removal of CompactDividerDecoration. We no longer uses dividers, so this is no longer needed.
alexbakker
force-pushed
the
no-compact-divider
branch
from
d880099
to
45ced0d
Compare
|
Whoops, fixed! |
michaelschattgen
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch addresses the following:
Example before and after: