Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph editor fubar, won't allow edits #122

Open
dreeves opened this issue May 20, 2020 · 4 comments
Open

Graph editor fubar, won't allow edits #122

dreeves opened this issue May 20, 2020 · 4 comments
Labels
ADO Question / what to Actually Do / much ado... BUG cnr (closed as) could not reproduce help wanted UVI ZzZ Postponed aka snoozed

Comments

@dreeves
Copy link
Member

dreeves commented May 20, 2020

I've seen this happen to my own goals but haven't figured out how to reproduce it. Now we have a user report (cpcallen again; thank you!!):

When "Graph" is selected everything seems normal:

image

But when I select "Editor", the page appears to be badly broken:

image

The data it is showing on the graph is actually for my email-inbox goal, even though exercise is selected, and changing the selected goal seems to have no effect at all.

cpcallen then tried a lot of things including incognito window and a different browser and even a different computer. So it doesn't sound like it's anything browser/client-side.

So this is a serious thing affecting at least 2 users but we need to figure out repro steps.

PS: cpcallen only has 8 goals so it's not limited to users like me with tons of goals. it could have to do with tons of datapoints though.

@dreeves dreeves added BUG help wanted ADO Question / what to Actually Do / much ado... UVI labels May 20, 2020
@cpcallen
Copy link
Contributor

cpcallen commented May 21, 2020

Reproduction (reliable, as far as I can see):

user = cpcallen
bgraph.js:5284 bgraph(1):show(), road is empty!
bgraph.js:1715 bgraph(2): Goal stats (cpcallen/email-inbox): 61.701171875ms
bgraph.js:1776 bgraph(2): Goal graph (cpcallen/email-inbox): 485.9130859375ms
bgraph.js:1715 bgraph(1): Goal stats (cpcallen/email-inbox): 55.791015625ms
bgraph.js:1776 bgraph(1): Goal graph (cpcallen/email-inbox): 618.243896484375ms
  • Click on "Editor" radio button. No further console output. Display changes, showing road editor as expected.

  • Choose exercise from goals drop-down. Console shows:

bgraph(1): Goal stats (cpcallen/exercise): 77.39404296875ms
bgraph.js:1776 bgraph(1): Goal graph (cpcallen/exercise): 1295.68603515625ms
bgraph.js:1715 bgraph(2): Goal stats (cpcallen/exercise): 58.82177734375ms
bgraph.js:5045 TypeError: Cannot read property '0' of undefined
    at updateYBHP (bgraph.js:3121)
    at updateGraphData (bgraph.js:4870)
    at SVGRectElement.zoomed (bgraph.js:1383)
    at H.apply (d3.v5.min.js:2)
    at kt (d3.v5.min.js:2)
    at w.emit (d3.v5.min.js:2)
    at w.zoom (d3.v5.min.js:2)
    at SVGRectElement.<anonymous> (d3.v5.min.js:2)
    at Pt.each (d3.v5.min.js:2)
    at g.transform (d3.v5.min.js:2)

Mixed in with this (but seemingly not in response to my input) were many many (400+) instances of:

Unchecked runtime.lastError: The message port closed before a response was received.

Since my exercise goal has an absurd number of road segments (thanks to beescheduler), I also tried my recently-added, two segment bedtime goal (after reloading, to clear any broken state) and got exactly the same error.

I do not get that error for all goals, though: in addition to email-inbox, my email-starred goal also loads up fine in the editor. (Having poked around a bit: I think these are the only ones which are YBHP.)

dreeves added a commit that referenced this issue May 22, 2020
@dreeves
Copy link
Member Author

dreeves commented May 24, 2020

@dreeves
Copy link
Member Author

dreeves commented Sep 14, 2020

This may be over-optimistic but you (@cpcallen) said that the bug didn't manifest for your YBHP goals and now everything is YBHP so... Maybe this came out in the wash?

I guess I can snooze it until we get another report of it at least. The road editor has been quite solid for user-me lately!

@dreeves dreeves added the ZzZ Postponed aka snoozed label Sep 14, 2020
@cpcallen
Copy link
Contributor

cpcallen commented Sep 16, 2020 via email

@dreeves dreeves added the cnr (closed as) could not reproduce label Apr 2, 2021
@dreeves dreeves changed the title Road editor fubar, won't allow edits Graph editor fubar, won't allow edits Jul 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ADO Question / what to Actually Do / much ado... BUG cnr (closed as) could not reproduce help wanted UVI ZzZ Postponed aka snoozed
Projects
None yet
Development

No branches or pull requests

2 participants