Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only real change here is the checking for user update permission. I didn't verify this, but it looked like before this change anybody could have changed any user's username.
There's a slight cost to the change - in the case where a user with USER_UPDATE is updating permissions for another user it'll check for the permission twice. I don't think that's a very expensive check, but if it is we could add a
if user_id == str(self.current_user.id):
check.