"beets.util.confit is deprecated; use confuse instead" after update to Beets 1.5 when running commands

[j-peeters]

Congrats with the update!
After updating Beets to 1.5 and running a command Beets gives me the following error:

/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/beets/util/confit.py:21: UserWarning: beets.util.confit is deprecated; use confuse instead
  warnings.warn("beets.util.confit is deprecated; use confuse instead")
Traceback (most recent call last):
  File "/Library/Frameworks/Python.framework/Versions/3.7/bin/beet", line 11, in <module>
    load_entry_point('beets==1.5.0', 'console_scripts', 'beet')()
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/beets/ui/__init__.py", line 1291, in main
    _raw_main(args)
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/beets/ui/__init__.py", line 1274, in _raw_main
    subcommands, plugins, lib = _setup(options, lib)
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/beets/ui/__init__.py", line 1153, in _setup
    plugins = _load_plugins(options, config)
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/beets/ui/__init__.py", line 1139, in _load_plugins
    plugins.send("pluginload")
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/beets/plugins.py", line 497, in send
    for handler in event_handlers()[event]:
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/beets/plugins.py", line 480, in event_handlers
    for plugin in find_plugins():
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/beets/plugins.py", line 315, in find_plugins
    _instances[cls] = cls()
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/beetsplug/lyrics.py", line 736, in __init__
    sources = self.sanitize_bs_sources(sources)
  File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/beetsplug/lyrics.py", line 763, in sanitize_bs_sources
    if source.REQUIRES_BS:
AttributeError: 'str' object has no attribute 'REQUIRES_BS'

I read in the change log that configuration library has been replaced by Confuse and that plugin developers needed to be aware of this, so my guess is that it has to do with some plugin.
In the warning message I can't find a reference to a specific plugin (or I must have missed it).
Does anyone know how to tackle this error message?
And thanks again for all the hard work on the new release!

[sampsyo]

The warning does indeed come from a plugin. Yeah, it's annoying that it doesn't give a traceback to show which plugin it's coming from… we should look into that! Maybe a feature request ticket is in order for that?

The crash, however, actually looks to be separate—it likely has nothing to do with the deprecation. It looks like a straight-up bug in the lyrics plugin. Would you mind filing a bug with some details so we can look into it?

[j-peeters]

Thanks @sampsyo
I filed the feature request.
Re: Lyrics, to make sure that it was not some config problem with the lyrics plugin I reinstalled 'requests' and 'beautifulsoup4'. After that it seems to work without the error so the problem was on my side.

[sampsyo]

Thanks for the update! I actually still think there's a bug here… we're supposed to silently fix up the configuration when BeautifulSoup is not installed; not crash with a traceback. Glancing at the code, I do see the mistake… so if you don't mind opening an issue (as opposed to a discussion thread), that would be awesome.

[j-peeters]

Will do

[j-peeters]

#4027
@sampsyo Please check if you can work with this, I'm not very experienced in writing bug reports.

[sampsyo]

LGTM; thanks, @janpeeters70!