Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow plugins to define the same flexible fields if they are of the same type #1059

Closed
pscn opened this issue Nov 4, 2014 · 0 comments · Fixed by #1061
Closed

Allow plugins to define the same flexible fields if they are of the same type #1059

pscn opened this issue Nov 4, 2014 · 0 comments · Fixed by #1061
Assignees
@pscn
Labels
feature features we would like to implement

Comments

@pscn
Copy link
Collaborator

pscn commented Nov 4, 2014

It should be possible for plugins to define the same flexible fields if they are of the same type. At the moment lastfmimport and mpdstats define 'play_count' which leads to:

beets.plugins.PluginConflictException: Plugin mpdstats defines flexible field play_count which has already been defined.
@pscn pscn closed this as completed Nov 4, 2014
@pscn pscn reopened this Nov 4, 2014
@pscn pscn closed this as completed Nov 4, 2014
@pscn pscn changed the title a Allow plugins to define the same flexible fields if they are of the same type Nov 4, 2014
@pscn pscn reopened this Nov 4, 2014
@pscn pscn mentioned this issue Nov 4, 2014
Closed
@pscn pscn added the feature features we would like to implement label Nov 4, 2014
@pscn pscn self-assigned this Nov 4, 2014
pscn added a commit that referenced this issue Nov 4, 2014
@pscn
Allow plugins to define the same flexible fields if they are of the same
2916753 
type #1059
@pscn pscn mentioned this issue Nov 4, 2014
Merged
sampsyo added a commit that referenced this issue Nov 5, 2014
@sampsyo
Merge pull request #1061 from sampsyo/types_conflict
e7d5d0e 
Allow plugins to define the same flexible fields if they are of the same type #1059
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pscn pscn

Labels
feature features we would like to implement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow plugins to define the same flexible fields if they are of the same type #1059 beetbox/beets
1 participant
@pscn