Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetchart: Check that image files are in fact files #1177

Closed
kelvinhammond opened this issue Dec 28, 2014 · 1 comment
Closed

fetchart: Check that image files are in fact files #1177

kelvinhammond opened this issue Dec 28, 2014 · 1 comment
Labels
bug bugs that are confirmed and actionable

Comments

@kelvinhammond
Copy link

I have no idea why it was a directory, I fixed it manually but still beets should probably check that what it is trying to copy to a file is actually a file and not some other type of "file".

Error: Is a directory while copying /Cashmere Cat - Mirror Maru (Remixes) - 2013/Folder.jpg to/Cashmere Cat - Mirror Maru (
Remixes) - 2013/cover.jpg

<music root>/Cashmere Cat - Mirror Maru (Remixes) - 2013/Folder.jpg was a directory with a file inside of it for the cover, not sure why it was like that but I fixed it.

This may be an issue with the cover art plugin, am not sure, it probably is.

@sampsyo sampsyo added the bug bugs that are confirmed and actionable label Dec 28, 2014
@sampsyo sampsyo changed the title Importer fails to copy Folder.jpg to cover.jpg when Folder.jpg is a directory fetchart: Check that image files are in fact files Dec 28, 2014
@sampsyo
Copy link
Member

sampsyo commented Dec 28, 2014

Thanks for the thorough report. The fetchart plugin should indeed verify that the stuff it finds are in fact files (i.e., with os.path.isfile).

brunal added a commit to brunal/beets that referenced this issue Jan 8, 2015
@sampsyo sampsyo closed this as completed in a7be928 Jan 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs that are confirmed and actionable
Projects
None yet
Development

No branches or pull requests

2 participants