Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetchart: check that the art found is a file #1211

Merged
merged 1 commit into from Jan 8, 2015

Conversation

brunal
Copy link
Collaborator

@brunal brunal commented Jan 8, 2015

Code + test. Fixes issue #1177

@sampsyo
Copy link
Member

sampsyo commented Jan 8, 2015

Awesome; this looks like just what we need. 🎩

@sampsyo sampsyo merged commit 2e1b0d5 into beetbox:master Jan 8, 2015
sampsyo added a commit that referenced this pull request Jan 8, 2015
Fetchart: check that the art found is a file
sampsyo added a commit that referenced this pull request Jan 8, 2015
@sampsyo
Copy link
Member

sampsyo commented Jan 8, 2015

Tiny GitHub protip: if you use the string "fix #someissue" or even "fixes #something", I think, it will automatically close the ticket when the PR is merged. I don't think it quite recognizes "fixes issue #something".

@brunal brunal deleted the fetchart-check-isfile branch January 9, 2015 11:11
@Freso
Copy link
Member

Freso commented Jan 10, 2015

https://help.github.com/articles/closing-issues-via-commit-messages/ has the full list of usable closing keywords.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants