Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

embedart: extractart command should respect art_filename config variable #1258

Closed
sread opened this issue Jan 22, 2015 · 1 comment
Closed

embedart: extractart command should respect art_filename config variable #1258

sread opened this issue Jan 22, 2015 · 1 comment
Labels
bitesize feature features we would like to implement

Comments

@sread
Copy link

sread commented Jan 22, 2015

When using the extractart command, the resulting image file should be named according to art_filename as in the fetchart plugin. Might be relevant for #1130 as well.

Great program!
@sampsyo sampsyo added feature features we would like to implement bitesize labels Jan 22, 2015
@sampsyo
Copy link
Member

sampsyo commented Jan 22, 2015

Good point. It's currently hardcoded to "cover". https://github.com/sampsyo/beets/blob/268dcb0008228912c305fc6e8818dafda3b48555/beetsplug/embedart.py#L91

@mried mried closed this as completed in b3803d3 Jan 23, 2015
brunal added a commit that referenced this issue Jan 23, 2015
@brunal
Embedart extraction: 'cover' is already the default
b30c697 
'cover' is already the default filename (in the absence of a custom
config) so there is no need to re-write that value in the embertart
plugin.

Improve #1258
mried added a commit that referenced this issue Jan 24, 2015
@mried
Changelog for #1258 (file name of extracted art is taken from art_fil…
54432d1 
…ename)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bitesize feature features we would like to implement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sampsyo @sread