Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve extractart to extract cover art of all albums for a query #1261

Closed
mried opened this issue Jan 23, 2015 · 3 comments · Fixed by #1263
Closed

Improve extractart to extract cover art of all albums for a query #1261

mried opened this issue Jan 23, 2015 · 3 comments · Fixed by #1263
Labels
feature features we would like to implement

Comments

@mried
Copy link
Collaborator

mried commented Jan 23, 2015

The current extractart command of the embedart plugin is only able to extract the cover art of a single file. If the query the user specifies results in more than one item, only the art of the first one is extracted.

I would like to improve the command such the user queries for albums (like ls -a command) and one cover art is extracted per album and placed inside the album folder. The command should try all files of an album until an art is found. The command could be executed like beet extractart -a <query>.

@mried mried added the feature features we would like to implement label Jan 23, 2015
brunal added a commit to brunal/beets that referenced this issue Jan 23, 2015
Don't stop at the first item but try them all.
Fix beetbox#1261
@brunal
Copy link
Collaborator

brunal commented Jan 23, 2015

Since I was working on embedart, here is a solution. I probably should add a test for it though...

@mried
Copy link
Collaborator Author

mried commented Jan 23, 2015

I don't think the change you made does what I wanted to do: It wont extract the art of all albums specified by a query. It'll still only extract one art file.

@brunal
Copy link
Collaborator

brunal commented Jan 23, 2015

Right... I read the issue too fast, sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature features we would like to implement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants