New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ReplayGain plugin with mp3gain backend is modifying source files. #1316
Comments
Hmm, this does seem like a problem. The intention with dropping that option was to never apply the adjustment to the files themselves; that was determined to be out of scope for the plugin. Do you have any clues about how we can force |
Update docs to remove non-existent `apply` option. Simplify tag-writing logic when scanning for replaygain.
What do you think of this approach? Removing Furthermore, the way Let me know what you think and I can submit a PR. |
What about album-level gain calculation? Will that still work without the -a flag? I also don't quite see what you're saying about the |
Correct, album-level calculation works without the Yes, the problem about the |
Ah, cool. Sounds good! If album-granularity analysis works either way, I think we can indeed just remove that line. No need for -e, I think, since we still separate out track and album values. |
Update docs to remove non-existent `apply` option. Simplify tag-writing logic when scanning for replaygain.
Got it. Let me fix the commit. I'm still relatively new to PRs and stuff. |
Update docs to remove non-existent `apply` option.
Stop applying mp3gain directly to files. Fixes #1316
If one enables the replaygain module using the mp3gain backend, the gain is being applied to the source files. Furthermore, the modifications are not reversible because the undo information is not being written to either source or destination files.
To reproduce:
Create this one-line ~/.config/beets/config.yaml:
Per the docs, this will default to automatically analyze for replaygain, using the command backend.
Now,
beet import -A
a file. I use this one, which has a222912248f934554ec2eaaf1b191f938607ffbab
sha1sum.The replaygain plugin calls mp3gain on the source with the "-r" parameter, which will apply the gain to the source file. Calling sha1sum on the source file after the import will show it has been modified.
Per the plugin docs, the gain should not be applied unless the
apply
config is set toyes
, but even then, I don't believe that the intention was to modify at the source, was it?By the way, the
apply
option was dropped from the plugin at 86ee30d. This is relatively easy to bring back, and I'd be happy to submit a PR fixing that omission, but the real problem is that even bringing that option/conditional check, the gain will still be applied to the source files.The text was updated successfully, but these errors were encountered: