thumbnails: Segmentation fault #1433
Comments
|
Wow, that looks bad. Can you please try narrowing this down in two dimensions?
Also, can you please describe your system setup? |
sampsyo
added
the
needinfo
|
Hi, I haven't had a lot of time to try and narrow it down, but I found I could consistently reproduce it with one folder (although I think I also had the issue with other folders before). When I disable all plugins, the issue goes away. It does not seem related to fetchart, embedart, chroma, discogs, mbsync, duplicates or replaygain My setup:
Please let me know if you need more info about my system. I'll try to test all plugins as quickly as possible. |
|
Thanks for the additional information. From your lists, are you saying that the crash does appear when you only have these plugins enabled: random thumbnails missing? If so, I'm inclined to guess it's the thumbnails plugin—especially since that traceback blames a call into native code inside the plugin! Is there any chance you can get the verbose output for one of these crashes? And in the mean time, @brunal, any ideas about why this ctypes call in the thumbnails plugin would segfault? I see there's a null check for that pointer just above, so it must somehow be the case that we're getting an invalid but non-null pointer from |
|
I can confirm the minimal configuration that reproduces this is thumbnails and fetchart. The verbose log is below: beet -v import Smoking\ Monkey Current thread 0x00007f4733fff700 (most recent call first): Thread 0x00007f4750204700 (most recent call first): |
sampsyo
added
bug
|
Great; thanks! Since I don't currently have a system running with the appropriate Freedesktop libraries, I'll defer to @brunal here. |
|
Hi, |
|
It is strange indeed. We probably even shouldn't rule out a bug in the gio library. Safe travels, @brunal! There's no hurry, of course. |
|
I can reproduce this on Fedora 21 also with glib 2.42.2 |
|
I have a probably related issue when issuing a direct call to the thumbnails plugin: Beets is 1.3.14, glib library is 2.44.1, running on Archlinux. |
|
Hi, |
|
As requested by @sampsyo, I'm adding my bit of info about this issue: I recently updated my Fedora 22 to 23. After the update, the thumbnails plugin segfaults. I have tested this issue in fresh VM installation of Fedora 22 and Fedora 23 – the same issue occurred on the newer OS. Both VMs ran newest beets and had ImageMagick installed ( …and the same config (output of fetchart:
cautious: yes
sources: coverart albumart google
auto: no
minwidth: 0
maxwidth: 0
cover_names:
- cover
- front
- art
- album
- folder
remote_priority: no
enforce_ratio: no
thumbnails:
auto: no
dolphin: no
force: no
embedart:
auto: no
compare_threshold: 0
ifempty: no
remove_art_file: no
maxwidth: 0
plugins: fuzzy fetchart embedart thumbnails
fuzzy:
threshold: 0.7
prefix: '~'On Fedora 22 the thumbnails plugin works correctly and the folder thumbnails are present in Nautilus: On Fedora 23 the thumbnails plugin causes segmentation fault: PIP version and installed packages on
The core dump is available at https://www.dropbox.com/s/sl2i3hs62fx7gi1/beets-coredump.zip?dl=0 . Unfortunately, I don't have the experience to debug this myself. Could this be related to the migration to Python 3 as the default in the newest release? |
|
Unfortunately, the fix suggested by @bcalou did not work for me – thumbnails still segfaults after setting |
Seems to address a segfault indicated in #1433, but there are still crashes lurking.
|
I think I've found and fixed the problem. Could someone who experienced it in the wild please confirm that the crash is gone? |
|
I don't have a Linux box to check that the thumbnail is here, but the crash is indeed gone 👍 |
|
I installed the newest Beets using |
|
Woohoo! Great news. |
Hi, I often see a segmentation fault when importing. I can't completely confirm, but I have the impression it happens when I get a prompt ("Apply, More candidates,...") and don't respond immediately.
I enabled the following plugins: fetchart embedart chroma discogs mbsync duplicates missing random thumbnails replaygain
Thread 0x00007fccf1ffb700 (most recent call first):
File "/home/bart/.virtualenv/beets/local/lib/python2.7/site-packages/audioread/ffdec.py", line 65 in run
File "/usr/lib/python2.7/threading.py", line 810 in __bootstrap_inner
File "/usr/lib/python2.7/threading.py", line 783 in __bootstrap
Current thread 0x00007fccf2ffd700 (most recent call first):
File "/home/bart/.virtualenv/beets/local/lib/python2.7/site-packages/beetsplug/thumbnails.py", line 268 in uri
File "/home/bart/.virtualenv/beets/local/lib/python2.7/site-packages/beetsplug/thumbnails.py", line 164 in thumbnail_file_name
File "/home/bart/.virtualenv/beets/local/lib/python2.7/site-packages/beetsplug/thumbnails.py", line 143 in make_cover_thumbnail
File "/home/bart/.virtualenv/beets/local/lib/python2.7/site-packages/beetsplug/thumbnails.py", line 131 in process_album
File "/home/bart/.virtualenv/beets/local/lib/python2.7/site-packages/beets/plugins.py", line 123 in wrapper
File "/home/bart/.virtualenv/beets/local/lib/python2.7/site-packages/beets/plugins.py", line 455 in send
File "/home/bart/.virtualenv/beets/local/lib/python2.7/site-packages/beets/library.py", line 1069 in set_art
File "/home/bart/.virtualenv/beets/local/lib/python2.7/site-packages/beetsplug/fetchart.py", line 362 in assign_art
File "/home/bart/.virtualenv/beets/local/lib/python2.7/site-packages/beets/plugins.py", line 123 in wrapper
File "/home/bart/.virtualenv/beets/local/lib/python2.7/site-packages/beets/plugins.py", line 455 in send
File "/home/bart/.virtualenv/beets/local/lib/python2.7/site-packages/beets/importer.py", line 661 in manipulate_files
File "/home/bart/.virtualenv/beets/local/lib/python2.7/site-packages/beets/importer.py", line 1366 in manipulate_files
File "/home/bart/.virtualenv/beets/local/lib/python2.7/site-packages/beets/util/pipeline.py", line 160 in coro
File "/home/bart/.virtualenv/beets/local/lib/python2.7/site-packages/beets/util/pipeline.py", line 347 in run
File "/usr/lib/python2.7/threading.py", line 810 in __bootstrap_inner
File "/usr/lib/python2.7/threading.py", line 783 in __bootstrap
Thread 0x00007fccf37fe700 (most recent call first):
File "/home/bart/.virtualenv/beets/local/lib/python2.7/site-packages/beets/dbcore/db.py", line 651 in query
File "/home/bart/.virtualenv/beets/local/lib/python2.7/site-packages/beets/dbcore/db.py", line 551 in _make_model
File "/home/bart/.virtualenv/beets/local/lib/python2.7/site-packages/beets/dbcore/db.py", line 522 in _get_objects
File "/home/bart/.virtualenv/beets/local/lib/python2.7/site-packages/beets/dbcore/db.py", line 609 in get
File "/home/bart/.virtualenv/beets/local/lib/python2.7/site-packages/beets/dbcore/db.py", line 823 in _get
File "/home/bart/.virtualenv/beets/local/lib/python2.7/site-packages/beets/dbcore/db.py", line 384 in load
File "/home/bart/.virtualenv/beets/local/lib/python2.7/site-packages/beets/importer.py", line 759 in reload
File "/home/bart/.virtualenv/beets/local/lib/python2.7/site-packages/beets/importer.py", line 1348 in plugin_stage
File "/home/bart/.virtualenv/beets/local/lib/python2.7/site-packages/beets/util/pipeline.py", line 183 in coro
File "/home/bart/.virtualenv/beets/local/lib/python2.7/site-packages/beets/util/pipeline.py", line 301 in run
File "/usr/lib/python2.7/threading.py", line 810 in __bootstrap_inner
File "/usr/lib/python2.7/threading.py", line 783 in __bootstrap
Thread 0x00007fccf3fff700 (most recent call first):
File "/usr/lib/python2.7/socket.py", line 387 in read
File "/usr/lib/python2.7/httplib.py", line 573 in read
File "/home/bart/.virtualenv/beets/local/lib/python2.7/site-packages/requests/packages/urllib3/response.py", line 186 in read
File "/home/bart/.virtualenv/beets/local/lib/python2.7/site-packages/requests/packages/urllib3/response.py", line 256 in stream
File "/home/bart/.virtualenv/beets/local/lib/python2.7/site-packages/requests/models.py", line 655 in generate
File "/home/bart/.virtualenv/beets/local/lib/python2.7/site-packages/beetsplug/fetchart.py", line 397 in _fetch_image
File "/home/bart/.virtualenv/beets/local/lib/python2.7/site-packages/beetsplug/fetchart.py", line 442 in art_for_album
File "/home/bart/.virtualenv/beets/local/lib/python2.7/site-packages/beetsplug/fetchart.py", line 348 in fetch_art
File "/home/bart/.virtualenv/beets/local/lib/python2.7/site-packages/beets/plugins.py", line 123 in wrapper
File "/home/bart/.virtualenv/beets/local/lib/python2.7/site-packages/beets/importer.py", line 1343 in plugin_stage
File "/home/bart/.virtualenv/beets/local/lib/python2.7/site-packages/beets/util/pipeline.py", line 183 in coro
File "/home/bart/.virtualenv/beets/local/lib/python2.7/site-packages/beets/util/pipeline.py", line 301 in run
File "/usr/lib/python2.7/threading.py", line 810 in __bootstrap_inner
File "/usr/lib/python2.7/threading.py", line 783 in __bootstrap
Thread 0x00007fcd00b35700 (most recent call first):
File "/usr/lib/python2.7/threading.py", line 340 in wait
File "/usr/lib/python2.7/Queue.py", line 168 in get
File "/home/bart/.virtualenv/beets/local/lib/python2.7/site-packages/beets/util/pipeline.py", line 292 in run
File "/usr/lib/python2.7/threading.py", line 810 in __bootstrap_inner
File "/usr/lib/python2.7/threading.py", line 783 in __bootstrap
Thread 0x00007fcd01336700 (most recent call first):
File "/home/bart/.virtualenv/beets/local/lib/python2.7/site-packages/beets/ui/init.py", line 156 in input_
File "/home/bart/.virtualenv/beets/local/lib/python2.7/site-packages/beets/ui/init.py", line 292 in input_options
File "/home/bart/.virtualenv/beets/local/lib/python2.7/site-packages/beets/ui/commands.py", line 643 in choose_candidate
File "/home/bart/.virtualenv/beets/local/lib/python2.7/site-packages/beets/ui/commands.py", line 707 in choose_match
File "/home/bart/.virtualenv/beets/local/lib/python2.7/site-packages/beets/importer.py", line 751 in choose_match
File "/home/bart/.virtualenv/beets/local/lib/python2.7/site-packages/beets/importer.py", line 1257 in user_query
File "/home/bart/.virtualenv/beets/local/lib/python2.7/site-packages/beets/util/pipeline.py", line 160 in coro
File "/home/bart/.virtualenv/beets/local/lib/python2.7/site-packages/beets/util/pipeline.py", line 301 in run
File "/usr/lib/python2.7/threading.py", line 810 in __bootstrap_inner
File "/usr/lib/python2.7/threading.py", line 783 in __bootstrap
Thread 0x00007fcd01b37700 (most recent call first):
File "/home/bart/.virtualenv/beets/local/lib/python2.7/site-packages/audioread/ffdec.py", line 134 in _get_info
File "/home/bart/.virtualenv/beets/local/lib/python2.7/site-packages/audioread/ffdec.py", line 90 in init
File "/home/bart/.virtualenv/beets/local/lib/python2.7/site-packages/audioread/init.py", line 91 in audio_open
File "/home/bart/.virtualenv/beets/local/lib/python2.7/site-packages/acoustid.py", line 262 in _fingerprint_file_audioread
File "/home/bart/.virtualenv/beets/local/lib/python2.7/site-packages/acoustid.py", line 321 in fingerprint_file
File "/home/bart/.virtualenv/beets/local/lib/python2.7/site-packages/beetsplug/chroma.py", line 65 in acoustid_match
File "/home/bart/.virtualenv/beets/local/lib/python2.7/site-packages/beetsplug/chroma.py", line 213 in fingerprint_task
File "/home/bart/.virtualenv/beets/local/lib/python2.7/site-packages/beetsplug/chroma.py", line 143 in fingerprint_task
File "/home/bart/.virtualenv/beets/local/lib/python2.7/site-packages/beets/plugins.py", line 123 in wrapper
File "/home/bart/.virtualenv/beets/local/lib/python2.7/site-packages/beets/plugins.py", line 455 in send
File "/home/bart/.virtualenv/beets/local/lib/python2.7/site-packages/beets/importer.py", line 1234 in lookup_candidates
File "/home/bart/.virtualenv/beets/local/lib/python2.7/site-packages/beets/util/pipeline.py", line 183 in coro
File "/home/bart/.virtualenv/beets/local/lib/python2.7/site-packages/beets/util/pipeline.py", line 301 in run
File "/usr/lib/python2.7/threading.py", line 810 in __bootstrap_inner
File "/usr/lib/python2.7/threading.py", line 783 in __bootstrap
Thread 0x00007fcd0dc76700 (most recent call first):
File "/usr/lib/python2.7/threading.py", line 359 in wait
File "/usr/lib/python2.7/threading.py", line 960 in join
File "/home/bart/.virtualenv/beets/local/lib/python2.7/site-packages/beets/util/pipeline.py", line 415 in run_parallel
File "/home/bart/.virtualenv/beets/local/lib/python2.7/site-packages/beets/importer.py", line 316 in run
File "/home/bart/.virtualenv/beets/local/lib/python2.7/site-packages/beets/ui/commands.py", line 870 in import_files
File "/home/bart/.virtualenv/beets/local/lib/python2.7/site-packages/beets/ui/commands.py", line 893 in import_func
File "/home/bart/.virtualenv/beets/local/lib/python2.7/site-packages/beets/ui/init.py", line 1094 in _raw_main
File "/home/bart/.virtualenv/beets/local/lib/python2.7/site-packages/beets/ui/init.py", line 1104 in main
File "/home/bart/.virtualenv/beets/bin/beet", line 11 in
[1] 1054 segmentation fault beet import J
The text was updated successfully, but these errors were encountered: