Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util.syspath should convert to unicode all paths #1485

Closed
glogiotatidis opened this issue Jun 1, 2015 · 2 comments
Closed

util.syspath should convert to unicode all paths #1485

glogiotatidis opened this issue Jun 1, 2015 · 2 comments

Comments

@glogiotatidis
Copy link
Contributor

When on python2.7 I run beet thumbnails I get this error

Traceback (most recent call last):
  File "/home/seadog/.virtualenvs/beets/bin/beet", line 9, in <module>
    load_entry_point('beets==1.3.13', 'console_scripts', 'beet')()
  File "/home/seadog/.virtualenvs/beets/local/lib/python2.7/site-packages/beets/ui/__init__.py", line 1104, in main
    _raw_main(args)
  File "/home/seadog/.virtualenvs/beets/local/lib/python2.7/site-packages/beets/ui/__init__.py", line 1094, in _raw_main
    subcommand.func(lib, suboptions, subargs)
  File "/home/seadog/.virtualenvs/beets/local/lib/python2.7/site-packages/beetsplug/thumbnails.py", line 77, in process_query
    self.process_album(album)
  File "/home/seadog/.virtualenvs/beets/local/lib/python2.7/site-packages/beetsplug/thumbnails.py", line 123, in process_album
    size = ArtResizer.shared.get_size(album.artpath)
  File "/home/seadog/.virtualenvs/beets/local/lib/python2.7/site-packages/beets/util/artresizer.py", line 205, in get_size
    return func(path_in)
  File "/home/seadog/.virtualenvs/beets/local/lib/python2.7/site-packages/beets/util/artresizer.py", line 123, in im_getsize
    util.syspath(path_in)])
  File "/home/seadog/.virtualenvs/beets/local/lib/python2.7/site-packages/beets/util/__init__.py", line 633, in command_output
    cmd=b' '.join(cmd),
UnicodeDecodeError: 'ascii' codec can't decode byte 0xce in position 21: ordinal not in range(128)

cmd contains [unicode, unicode, unicode, str] where str is the path.

glogiotatidis added a commit to glogiotatidis/beets that referenced this issue Jun 1, 2015
glogiotatidis added a commit to glogiotatidis/beets that referenced this issue Jun 1, 2015
@untitaker
Copy link
Collaborator

It seems beets uses unicode_literals, this is one of the grave consequences of it.

@sampsyo
Copy link
Member

sampsyo commented Jun 2, 2015

Perfect fix; thanks, @untitaker.

LordSputnik pushed a commit to LordSputnik/beets that referenced this issue Jul 6, 2015
LordSputnik pushed a commit to LordSputnik/beets that referenced this issue Jul 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants