Fix typos #1803
Merged
Fix typos #1803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 6, 2016 09:21
We should warn users that the corresponding config key changed accordingly.
My bad, rebased before I pushed and forgot to check the tests after the rebase
|
I think we should support the both, although probably have typo-ed version un-documented. |
JesseWeinstein
force-pushed
the
fix-typos
branch
from
2394f97
to
e319d3c
Compare
|
Yeah from a semver point of view that would make the most sense. I'm on it. |
|
I pushed the code for backwards compatiblity. We just need tests and changelog before merging. I'll try to write the tests for the backwards compatibility of play asap, but I doubt I'll have the time to do it today. |
JesseWeinstein
force-pushed
the
fix-typos
branch
from
e319d3c
to
d4ccc10
Compare
|
I've added a test; we just need a changelog entry. |
|
You can merge fix-typos from the main repo into your PR and then I'll merge into master! ☀️ E: Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1802