fetchart uses .jpg, extractart uses .jpeg

[tweitzel]

The extractart command in the embedart plugin uses the string output of imghdr.what as an extension. That's "jpeg."

beets/beets/art.py

Line 197 in db782a2

ext = imghdr.what(None, h=art)

Meanwhile, over in fetchart, it seems to use the first entry in IMAGE_EXTENSIONS for mime type image/jpeg, which is .jpg.

beets/beetsplug/fetchart.py

Line 44 in db782a2

CONTENT_TYPES = {

To reproduce:

Import something with no art, but has jpeg art in a configured fetchart source.
beet fetchart album
beet embedart album
beet extractart album
now you have cover.jpg and cover.jpeg or sometimes cover.1.jpeg or sometimes cover.1.jpg... it's kind of a big mess and seems weirdly nondeterministic at times.

This is normally harmless, but sometimes results in excessive clutter when re-importing old things.

[sampsyo]

Thanks! We should definitely make that consistent.

[nathdwek]

This should be a quick fix. This seems to indicate jpg is the most commonly used extension, so I would advocate for it to be used.

[sampsyo]

Sounds good to me. Staying consistent with fetchart seems more useful than obeying extractart, which is less commonly used.

[nathdwek]

BTW this makes me realize that my fix in #1545 should have targeted this too, but it didn't, and extractart fails on the same types of images for the same reason:

$ beet -l beetsdb.db -d beetsdir/ embedart  -f /f/tmp/beetsdir/ZZ\ Top/Tres\ hombres/only-magic-bytes.jpg
$ beet -l beetsdb.db -d /beetsdir/ extractart 
embedart: Unknown image type in /f/tmp/beetsdir/ZZ Top/Tres hombres/08 La Grange.mp3

I will try to bring all of this under one umbrella while fixing this issue.