Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

badfiles: Continue to other files if validator command is not found or exits with an error #2430

Closed
karpinski opened this issue Feb 8, 2017 · 3 comments
Labels
bug bugs that are confirmed and actionable

Comments

@karpinski
Copy link
Contributor

The execution exits with an error if mp3val or flac validators aren't installed. On the other hand, for extensions other than mp3 or flac which aren't included in the plugin's config, information is logged that the validator is missing and the execution moves on to checking the rest of the files.

I think this behaviour should be consistent for all extensions, also in cases when a validator is specified in the plugin's config, but it's not actually installed.

I am happy to send a PR with a fix for this!

@sampsyo sampsyo added the bug bugs that are confirmed and actionable label Feb 8, 2017
@sampsyo sampsyo changed the title Badfiles plugin: continue to other files if no validator was found for an extension badfiles: Continue to other files if validator command is not found or exits with an error Feb 8, 2017
@sampsyo
Copy link
Member

sampsyo commented Feb 8, 2017

Good call! Yes, this is definitely how it should work—it should use self._log.error() to produce an error message and just continue on instead of halting the whole process.

Thanks for looking into it!

@savagemechanic
Copy link

This issue should be closed

@sampsyo
Copy link
Member

sampsyo commented Mar 15, 2017

Indeed; thanks!

@sampsyo sampsyo closed this as completed Mar 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs that are confirmed and actionable
Projects
None yet
Development

No branches or pull requests

3 participants