Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

badfiles: config options/command for fixing files #3126

Open
Wyrrrd opened this issue Jan 22, 2019 · 5 comments
Open

badfiles: config options/command for fixing files #3126

Wyrrrd opened this issue Jan 22, 2019 · 5 comments
Labels
feature features we would like to implement

Comments

@Wyrrrd
Copy link

Wyrrrd commented Jan 22, 2019

How about a separate config entry for commands to fix bad files instead of just listing them. Also one could possibly run a separate command (for example beet fix or beet bad -f ) to fix every file in the library instead of just checking.

Suggested config structure:

badfiles:
    check:
        mp3: mp3val
        ...
    fix:
        mp3: mp3val -f -nb
        ...
@sampsyo sampsyo added the feature features we would like to implement label Jan 22, 2019
@sampsyo
Copy link
Member

sampsyo commented Jan 22, 2019

Sounds like a good idea! Have any leads on fixer commands for other formats?

@Wyrrrd
Copy link
Author

Wyrrrd commented Jan 23, 2019

Nothing compiled for now... For .flac and .ogg files, supplying a script that decodes and reencodes while preserving metadata should work for some errors.

For .ogg the procedure is described here, for example.

@Holzhaus
Copy link
Contributor

Ogg Vobis is a lossy format, and re-encoding the files will will lead to quantization errors and thus an audible loss of quality. Maybe it is possible to use oggz or ffmpeg to rewrite the file without re-encoding.

@phirestalker
Copy link

Just having an option to set the command for fixing the files would be great. In my case, I create a par2 file for each song on import. I would set the "fix" option to run a par2 repair on it.

@simonmcnair
Copy link

Repairing files doesn't normally work imo. You'll get a skip where it has removed the audio piece that is corrupt. I'd rather not have a bad file, than have a poor file in a music collection. Just my 2p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature features we would like to implement
Projects
None yet
Development

No branches or pull requests

5 participants