Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chroma: fingerprint/submit commands don't lookup or write the item's acoustid_id #5001

Open
Maxr1998 opened this issue Nov 23, 2023 · 1 comment
Labels
needinfo We need more details or follow-up from the filer before this can be tagged "bug" or "feature."

Comments

@Maxr1998
Copy link
Contributor

Problem

Currently, only the import process (via chroma.acoustid_match writes to the item's acoustid_id field. When using beet fingerprint or beet submit for tracks already in the library, only the acoustid_fingerprint field is written.

I confirmed this by looking at the source of the latest master. The cli command calls fingerprint_item, and not fingerprint_task (or acoustid_match), which seems to be only used during the import process.
item.acoustid_id is not written in other places.

@sampsyo
Copy link
Member

sampsyo commented Nov 25, 2023

Hmm… could you perhaps say a little more about what you are hoping will happen here?

One important thing to remember is that the Chromaprint/Acoustid system has two parts: computing the fingerprint (a local operation), and looking the fingerprint up in a big global database to get its ID (which uses the Acoustid server). beet fingerprint is just supposed to analyze the actual audio data and compute the fingerprint. Submission is supposed to tell the server about metadata, but it is most useful in situations where the server doesn't even have an ID for the song yet.

It seems like neither function should do the server lookup required to get an ID… maybe there is some other arrangement you're hoping for?

@sampsyo sampsyo added the needinfo We need more details or follow-up from the filer before this can be tagged "bug" or "feature." label Nov 25, 2023
Maxr1998 added a commit to Maxr1998/beets that referenced this issue Dec 15, 2023
Raises an exception if multiple plugins provide template functions for the same field.

Closes beetbox#5001, supersedes beetbox#5003.
Maxr1998 added a commit to Maxr1998/beets that referenced this issue Dec 15, 2023
Raises an exception if multiple plugins provide template functions for the same field.

Closes beetbox#5001, supersedes beetbox#5003.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needinfo We need more details or follow-up from the filer before this can be tagged "bug" or "feature."
Projects
None yet
Development

No branches or pull requests

2 participants