Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back NO_COLOR support? #5028

Closed
djl opened this issue Dec 6, 2023 · 3 comments · Fixed by #5034
Closed

Bring back NO_COLOR support? #5028

djl opened this issue Dec 6, 2023 · 3 comments · Fixed by #5034
Labels
bug bugs that are confirmed and actionable

Comments

@djl
Copy link
Member

djl commented Dec 6, 2023

Back in 2019 I added support for the NO_COLOR environment variable. This was removed in be290e5 as part of a refactor. Unless I'm mistaken it seems there's no way to disable colors from the command line anymore. It must be done in the config file. That's really inconvenient.

What was the reason for removing NO_COLOR support? Could it be brought back?

@JOJ0
Copy link
Member

JOJ0 commented Dec 6, 2023

I'm very sorry about this. There was no particular reason this does not work anymore. I assume it is just an oversight that this was kicked out in our recent major UI overhaul PR. I also don't have an immediate answer on how difficult it will be to bring that feature back. If you happen to have insight and resources on how to proceed that would be super-helpful and very much appreciated.

Sorry again and thanks a lot for the report! Very helpful already!

@jackwilsdon jackwilsdon added the bug bugs that are confirmed and actionable label Dec 6, 2023
@djl
Copy link
Member Author

djl commented Dec 6, 2023

No worries! I think the solution should be as simple as bringing back the "NO_COLOR" in os.environ check. I'll test this and have a PR up later.

@JOJ0
Copy link
Member

JOJ0 commented Dec 6, 2023

That sounds perfect!!! Thanks!

djl added a commit that referenced this issue Dec 7, 2023
djl added a commit that referenced this issue Dec 12, 2023
michaeldiazh pushed a commit to michaeldiazh/beets that referenced this issue Feb 19, 2024
michaeldiazh pushed a commit to michaeldiazh/beets that referenced this issue Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs that are confirmed and actionable
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants