Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BPD: Update to newer MPD protocol version #800

Closed
simonwjackson opened this issue Jun 2, 2014 · 8 comments

Comments

Projects
None yet
6 participants
@simonwjackson
Copy link

commented Jun 2, 2014

When running ncmpcpp, i get the following error message:

NCMPCPP: MPD < 0.16.0 is not supported

Can this be resolved by reporting a different version number to the clients? Or is there a fundamental difference in the code?

@sampsyo sampsyo changed the title Some clients don't support BPD BPD: Update to newer MPD protocol version Jun 2, 2014

@sampsyo

This comment has been minimized.

Copy link
Member

commented Jun 2, 2014

Thanks for pointing this out. If you (or anyone) is interested in tackling this, the first step will be to answer that question: identify what has changed between the protocol we implement and 0.16.0+.

@sampsyo sampsyo added the feature label Jun 2, 2014

@tiagoad

This comment has been minimized.

Copy link
Contributor

commented Nov 9, 2014

According to the mpd command reference, it seems like the new stuff after 0.13.0 (the version implemented by the bpd plugin) are:

  • idle command (probably the most important. it is the reason ncmpcpp can only work with >0.16.0)
  • single, consume, nextsong, nextsongid, elapsed parameters in the status command
  • single, consume playback options
  • auto replay gain mode
  • move playlist command
  • playlistinfo command
  • rangeid playlist command

I will look into implementing these changes so we can bump the proto version up to 0.19.0

@sampsyo

This comment has been minimized.

Copy link
Member

commented Nov 9, 2014

Fantastic; thanks for looking into it!

@bearcatsandor

This comment has been minimized.

Copy link

commented Nov 9, 2014

Thank you Tiago! I've been wanting BPD working again for a long time now.
This is a dream come true. (Seriously, i was dreaming about this the other
night. My girlfriend tells me i'm a geek or something).

On Sun, Nov 9, 2014 at 11:28 AM, Adrian Sampson notifications@github.com
wrote:

Fantastic; thanks for looking into it!


Reply to this email directly or view it on GitHub
#800 (comment).

Bearcat M. Şándor
Voice: 872.CAT.SOUL (872.228.7685)
Fax: 406.235.7070
My public pgp key is included for verification of my identity

@marcaddeo

This comment has been minimized.

Copy link
Contributor

commented Dec 28, 2014

Any progress on this? Would love to be able to use ncmpcpp with bpd 😄

@sampsyo

This comment has been minimized.

Copy link
Member

commented Dec 28, 2014

No news that's not listed here. If you're interested, please consider contributing.

@arcresu

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

If anyone is still following this issue, this is an update to say that we're almost there! I have a pull request in progress (#3214) that is aiming to finish off the final missing parts of the MPD protocol support for 0.16. It's at a stage where it's now talking to ncmpcpp and basic things like changing songs seem to work.

Simple clients like mpdscribble, mpDris and mpc all seem to be working OK. The more complex clients like MPDroid, M.A.L.P. and ncmpcpp are all still broken to varying degrees. I've been keeping a list of problems in the description of the PR and gradually addressing them. If you'd like to help this effort it'd be great to test out some of your favourite MPD clients with the code in that PR and report back about any further issues you find.

@bearcatsandor

This comment has been minimized.

Copy link

commented Apr 18, 2019

@arcresu Thanks for the hard work!

@arcresu arcresu added this to the Modern MPD support milestone Jun 3, 2019

@arcresu arcresu closed this in #3214 Jun 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.