Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add authentication to discogs plugin #1040

Merged
merged 1 commit into from Oct 26, 2014
Merged

Conversation

multikatt
Copy link
Collaborator

This PR addresses #1027.
If a token is not set up yet it will create a link on discogs.com to do so and prompt the user for the code generated there.

@sampsyo
Copy link
Member

sampsyo commented Oct 26, 2014

Awesome; thanks for sorting this out!

I'm actually going to apply for an official consumer key/secret for beets. Users can of course get their own, but this should ease the burden.

It would also be even nicer if the OAuth tokens could be saved automatically in a state file rather than requiring config editing. I'll look into that.

@sampsyo sampsyo merged commit d9c9e06 into beetbox:master Oct 26, 2014
sampsyo added a commit that referenced this pull request Oct 26, 2014
Add authentication to discogs plugin
sampsyo added a commit that referenced this pull request Oct 26, 2014
sampsyo added a commit that referenced this pull request Oct 26, 2014
sampsyo added a commit that referenced this pull request Oct 26, 2014
@sampsyo
Copy link
Member

sampsyo commented Oct 26, 2014

Okay! Merged with automatic token-saving. Thanks again.

@multikatt
Copy link
Collaborator Author

Cool, nice autosaving solution. Thanks!

@multikatt multikatt deleted the discogs_auth branch October 26, 2014 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants