Added slash separator to DateField and more comments styles to MediaFile #1043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| datestring = super(DateField, self).__get__(mediafile, None) | ||
| if isinstance(datestring, basestring): | ||
| datestring = re.sub(r'[Tt ].*$', '', unicode(datestring)) | ||
| items = unicode(datestring).split('-') | ||
| items = re.split('-|/', unicode(datestring)) |
There was a problem hiding this comment.
Looks good (although I might have arbitrarily gone with [-/] for the regex 😃). We should add a test.
There was a problem hiding this comment.
Yes, you are right. I will change this and add a test.
sampsyo
added a commit
that referenced
this pull request
Oct 28, 2014
Added slash separator to DateField and more comments styles to MediaFile
|
Thanks for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added some StorageStyles to the comments field, which I have seen appearing in actual files.
Additionally, I have changed the DateField to also allow slashed as separator. An example file where this date format appears can be found at http://commons.wikimedia.org/wiki/File:Tromboon-sample.ogg