convert: copy album art when copying or transcoding. #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only implemented to work when matching albums instead of tracks (-a option). Disabled by default in the configuration of 'convert'. fix indentation. Fix Travis nagging over indentation (hopefully). Finally pep8 conforming.
alderz
force-pushed
the
convert_copy_album_art
branch
from
8c3ffc1
to
94c268d
Compare
| @@ -322,6 +369,7 @@ def __init__(self): | |||
| u'embed': True, | |||
| u'paths': {}, | |||
| u'never_convert_lossy_files': False, | |||
| u'copy_album_art': False | |||
There was a problem hiding this comment.
Smallest possible suggestion: please add a trailing comma. 😃
|
Hey; this looks fantastic! ✨ Thanks for contributing. The patch looks perfect. Would you mind adding a mention of the new config option to the plugin's documentation page ( |
|
Done! 😃 |
|
Fantastic! Thanks again. 🐟 🚀 |
sampsyo
added a commit
that referenced
this pull request
Nov 2, 2014
convert: copy album art when copying or transcoding.
sampsyo
added a commit
that referenced
this pull request
Nov 2, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only implemented to work when matching albums instead of tracks (-a option).
Disabled by default in the configuration of 'convert'.
Please, @sampsyo , take a look at the code.
Referencing #1050.