Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zero: Can delete embedded images #1129

Merged
merged 1 commit into from Dec 1, 2014
Merged

Conversation

geigerzaehler
Copy link
Collaborator

Fixes #1100.

I also propose we add the media file fields to the output of beet fields. Currently the documentation for the zero plugin refers to the ouput of beet fields for a list of tags that can be zeroed. This is not quite correct as not all fields are written to the tags.

@sampsyo
Copy link
Member

sampsyo commented Dec 1, 2014

Again, this looks great, and thanks for including the tests. I'll merge this now.

You're right that the pointer in the docs is indeed incorrect, modifying the beet fields output does seem like the right solution. To make the output most intelligible, maybe we should avoid repetition since the fields are so similar for the two sets? For example, we could use a --tags flag or somesuch to explicitly request the MediaFile fields instead of the Item fields, or we could mark the MF fields in the default list somehow (e.g., with an asterisk *).

@sampsyo sampsyo merged commit e2b2a50 into beetbox:master Dec 1, 2014
sampsyo added a commit that referenced this pull request Dec 1, 2014
zero: Can delete embedded images

Conflicts:
	docs/changelog.rst
@jgeboski
Copy link

jgeboski commented Dec 1, 2014

Kudos!

@geigerzaehler geigerzaehler deleted the zero-images branch December 2, 2014 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zero: Permit stripping album art
3 participants