Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetchart: Use success coloring if album art is found #1512

Merged
merged 2 commits into from Jun 23, 2015
Merged

fetchart: Use success coloring if album art is found #1512

merged 2 commits into from Jun 23, 2015

Conversation

somasis
Copy link
Contributor

@somasis somasis commented Jun 20, 2015

This changes the 'has album art' message to use the green color used for success. I just think it makes it easier on the eyes.

@sampsyo
Copy link
Member

sampsyo commented Jun 20, 2015

Hmm... I like the notion, but it's also currently useful to have the cases where beets actually did new work to find album art stand out in the log. If everything but failure looks green, this is harder to see. Maybe we should be using a different color?

@somasis
Copy link
Contributor Author

somasis commented Jun 20, 2015

Blue? Yellow?

@sampsyo
Copy link
Member

sampsyo commented Jun 20, 2015

Good question; it's of course very subjective. 😃 Maybe yellow, since we already use that for an intermediate state? Or lightgray since we sort of want it to fade into the background?

@somasis
Copy link
Contributor Author

somasis commented Jun 22, 2015

How's that? lightgray (or, text_highlight_minor) sounded good to me.

@sampsyo
Copy link
Member

sampsyo commented Jun 23, 2015

Looks great! Thank you!

sampsyo added a commit that referenced this pull request Jun 23, 2015
fetchart: Use success coloring if album art is found
@sampsyo sampsyo merged commit 0a3e929 into beetbox:master Jun 23, 2015
sampsyo added a commit that referenced this pull request Jun 23, 2015
LordSputnik pushed a commit to LordSputnik/beets that referenced this pull request Jul 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants