Embedart: remove_art_file on import #1675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 30, 2015 17:04
Should fix #1662. I think the fix is easy. Don't know if it's clean though. Did some tests (+/- 10 albums), all successful. This is the first time I'm using python so please let me know what I should improve:)
| @@ -80,7 +80,7 @@ def embed_func(lib, opts, args): | |||
| art.embed_album(self._log, album, maxwidth, False, | |||
| compare_threshold, ifempty) | |||
|
|
|||
| if remove_art_file and album.artpath is not None: | |||
| if remove_art_file and album.artpath: | |||
There was a problem hiding this comment.
@Kraymer, I assume this line can be changed as well?
|
Awesome! Thank you for looking into this. A bit of refactoring will avoid code duplication. Then, we'll just need a changelog entry and we'll be ready to merge. Thanks again! ✨ |
Damn it, that was really hard for me:D. First time seriously using python. Please review it carefuly.
|
You're welcome. I was really struggling with the function. I probably made some mistakes and t.b.h. I'm a bit stuck now... |
|
You were just missing a : at the end of the function declaration. Fixing now and merging. |
sampsyo
added a commit
that referenced
this pull request
Nov 3, 2015
Embedart: remove_art_file on import
sampsyo
added a commit
that referenced
this pull request
Nov 3, 2015
sampsyo
added a commit
that referenced
this pull request
Nov 3, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #1662.
I think the fix is easy. Don't know if it's clean though. Did some tests (+/- 10 albums), all successful. This is the first time I'm using python so please let me know what I should improve:)