Fix lastimport #1574 (LastFM API change) #1797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also changed from using the library.getTracks API method to user.getTopTracks, since Last.fm has broken the former.
LordSputnik
changed the title
|
Truly awesome! Thanks for looking at this---I didn't know there was an alternative API endpoint we could use. 🎉 And thanks for updating the docs too! It looks like the tests may need to be updated to sync with the new version. And we'll also need a changelog, after which this should be good to merge. |
|
Ah, looks like I have any error in the docs - will get that fixed and changelog done. |
|
Perfect; thanks again! ✨ |
sampsyo
added a commit
that referenced
this pull request
Jan 4, 2016
Fix lastimport #1574 (LastFM API change)
|
Thanks @LordSputnik |
|
Thank you for fixing this. I am updating beets via pip, when will this fix be available there? It's still not working on the current version I have updated to. |
|
As soon as we do a new release. If you need the fix sooner, you can consider running from source (as described in the FAQ). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1574 by changing the API method from library.getTracks to user.getTopTracks, which returns similar information (mbid, artist, title, playcount).
Also, I've replaced the custom HTTP request (using requests) with the pylast library, which is already a dependency of lastgenre.