Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert SKIP_SLOW_TESTS to its own decorator #1809

Merged
merged 4 commits into from
Jan 13, 2016

Conversation

JesseWeinstein
Copy link
Contributor

No description provided.

@sampsyo
Copy link
Member

sampsyo commented Jan 13, 2016

Great! Feel free to merge at will.

I would advocate for slow_test for PEP-8 compliance (instead of matching unittest's camelCase aberration), but to each their own.

JesseWeinstein added a commit that referenced this pull request Jan 13, 2016
Convert SKIP_SLOW_TESTS to its own decorator
@JesseWeinstein JesseWeinstein merged commit 49feaf2 into master Jan 13, 2016
@JesseWeinstein JesseWeinstein deleted the slow_test_decorator branch January 13, 2016 06:17
@diego-plan9
Copy link
Member

Apologies for "reviving" this pull request, but I'm wondering if there are some guidelines or metric on when to use the slow_test decorator, @JesseWeinstein? I'm in the process of writing some more tests for the edit plugin at #1846 and would love some clarification on it's intended usage!

@JesseWeinstein
Copy link
Contributor Author

Happy to clarify! I added it to tests that took a perceptible time to run -- i.e. all 106 non-slow tests in test_ui.py took 4.217 seconds for me to run just now (i.e. 0.04 seconds per test), while one of the slow ones, CompletionTest, took 1.121 seconds just by itself. So I'd say probably add @slow_test to tests that take more than a tenth of a second to run, and certainly add it to tests that take more than a whole second to run.

@diego-plan9
Copy link
Member

Thanks for the hints, sounds like a quite sensible guideline!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants