beets.library.Library adds custom bytelower function to all connections, not just one #2390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! ✨ Does this look right to you, @jrobeson? |
|
I think so, but I also got it wrong in the first place, because I thought the sqlite connection management was simpler than it was! |
sampsyo
added a commit
that referenced
this pull request
Jan 15, 2017
beets.library.Library adds custom bytelower function to all connections, not just one
sampsyo
added a commit
that referenced
this pull request
Jan 15, 2017
|
Everything seems in order—thanks for the separate pull request, @irskep! ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue with multithreading I found when working on #2389.